Messages in this thread Patch in this message | | | From | Greg Kroah-Hartman <> | Subject | [ 02/27] ASoC: core: Fix to check return value of snd_soc_update_bits_locked() | Date | Sun, 14 Apr 2013 19:43:01 -0700 |
| |
3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Joonyoung Shim <jy0922.shim@samsung.com>
commit 0eaa6cca1f75e12e4f5ec62cbe887330fe3b5fe9 upstream.
It can be 0 or 1 return value of snd_soc_update_bits_locked() when it is success. So just check return value is negative.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- sound/soc/soc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -2959,7 +2959,7 @@ int snd_soc_put_volsw_range(struct snd_k val = val << shift; ret = snd_soc_update_bits_locked(codec, reg, val_mask, val); - if (ret != 0) + if (ret < 0) return ret; if (snd_soc_volsw_is_stereo(mc)) {
| |