Messages in this thread | | | Subject | Re: [PATCH 1/2] x86: Change trap definitions to enumerated values | From | Steven Rostedt <> | Date | Tue, 03 May 2011 18:54:36 -0400 |
| |
On Tue, 2011-05-03 at 15:41 -0700, Michael Rubin wrote: > On Tue, May 3, 2011 at 12:00 PM, Vaibhav Nagarnaik > <vnagarnaik@google.com> wrote: > > Would it make better sense to separate this patch into 2 patches, the first > > one replacing the numbers to enums and the second one adding the tracepoints? > > Yes please do that. > Each patch should stand on its own with one simple purpose if possible.
Agreed. Don't break up patches just because of size, but instead with purpose. Usually this breaks up large patches as you want to build up something, piece by piece, where each piece has a specific, easy to understand goal.
This is actually what is taking me so long to get my ftrace rewrite out. Not the actual work, but coming up with a way to break up that work in logical steps, that makes it easy to understand and review.
-- Steve
| |