lkml.org 
[lkml]   [2011]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/2] x86/kernel/cpu/mcheck/mce-inject.c: Add mce inject driver exit
Date
From: Fenghua Yu <fenghua.yu@intel.com>

Gracefully remove mce_inject driver. This avoids rebooting machine if one wants
to release the driver. It makes the driver more useful for debugging mce issues
or debugging the driver itself. And the mce code is more clean and reasonable.

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Acked-by: Tony Luck <tony.luck@intel.com>
---
arch/x86/kernel/cpu/mcheck/mce-inject.c | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce-inject.c b/arch/x86/kernel/cpu/mcheck/mce-inject.c
index 0ed633c..9966a61 100644
--- a/arch/x86/kernel/cpu/mcheck/mce-inject.c
+++ b/arch/x86/kernel/cpu/mcheck/mce-inject.c
@@ -179,7 +179,7 @@ static void raise_mce(struct mce *m)
}

/* Error injection interface */
-static ssize_t mce_write(struct file *filp, const char __user *ubuf,
+static ssize_t mce_write_inject(struct file *filp, const char __user *ubuf,
size_t usize, loff_t *off)
{
struct mce m;
@@ -210,17 +210,25 @@ static ssize_t mce_write(struct file *filp, const char __user *ubuf,
return usize;
}

-static int inject_init(void)
+static int __init inject_init(void)
{
if (!alloc_cpumask_var(&mce_inject_cpumask, GFP_KERNEL))
return -ENOMEM;
printk(KERN_INFO "Machine check injector initialized\n");
- mce_chrdev_ops.write = mce_write;
+ mce_write_register(mce_write_inject);
register_die_notifier(&mce_raise_nb);
return 0;
}

+static void __exit inject_exit(void)
+{
+ mce_write_unregister();
+ unregister_die_notifier(&mce_raise_nb);
+ free_cpumask_var(mce_inject_cpumask);
+}
+
module_init(inject_init);
+module_exit(inject_exit);
/*
* Cannot tolerate unloading currently because we cannot
* guarantee all openers of mce_chrdev will get a reference to us.
--
1.7.2


\
 
 \ /
  Last update: 2011-05-04 00:49    [W:0.026 / U:2.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site