lkml.org 
[lkml]   [2011]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] uio/pdrv_genirq: Add OF support
On Tue, May 03, 2011 at 10:34:12PM +0200, Wolfram Sang wrote:
> On Mon, May 02, 2011 at 08:51:55AM +0200, Michal Simek wrote:
> > Adding OF binding to genirq.
> > Version string is setup to the "devicetree".
> >
> > Compatible string is not setup for now but you can add your
> > custom compatible string to uio_of_genirq_match structure.
> >
> > For example with "vendor,device" compatible string:
> > static const struct of_device_id __devinitconst uio_of_genirq_match[] = {
> > { .compatible = "vendor,device", },
> > { /* empty for now */ },
> > };
> >
> > Signed-off-by: Michal Simek <monstr@monstr.eu>
>
> [...]
>
> > + /* alloc uioinfo for one device */
> > + uioinfo = kzalloc(sizeof(*uioinfo), GFP_KERNEL);
>
> kfree in remove?

Oh yes. Missed that one. It should probably look like the "bad0" case in probe().

Thanks,
Hans


\
 
 \ /
  Last update: 2011-05-04 00:17    [W:0.050 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site