Messages in this thread | | | Date | Wed, 4 May 2011 00:14:40 +0200 | From | "Hans J. Koch" <> | Subject | Re: [PATCH v4] uio/pdrv_genirq: Add OF support |
| |
On Tue, May 03, 2011 at 10:34:12PM +0200, Wolfram Sang wrote: > On Mon, May 02, 2011 at 08:51:55AM +0200, Michal Simek wrote: > > Adding OF binding to genirq. > > Version string is setup to the "devicetree". > > > > Compatible string is not setup for now but you can add your > > custom compatible string to uio_of_genirq_match structure. > > > > For example with "vendor,device" compatible string: > > static const struct of_device_id __devinitconst uio_of_genirq_match[] = { > > { .compatible = "vendor,device", }, > > { /* empty for now */ }, > > }; > > > > Signed-off-by: Michal Simek <monstr@monstr.eu> > > [...] > > > + /* alloc uioinfo for one device */ > > + uioinfo = kzalloc(sizeof(*uioinfo), GFP_KERNEL); > > kfree in remove?
Oh yes. Missed that one. It should probably look like the "bad0" case in probe().
Thanks, Hans
| |