Messages in this thread | | | Date | Tue, 3 May 2011 17:29:14 -0400 | From | Mathieu Desnoyers <> | Subject | Re: [RFC patch 29/32] trace event asoc remove semicolons |
| |
* Steven Rostedt (rostedt@goodmis.org) wrote: > On Tue, 2011-05-03 at 15:24 +0100, Mark Brown wrote: > > On Tue, May 03, 2011 at 03:14:37PM +0100, Mark Brown wrote: > > > OK, now I see patch 1 I understand why you're doing this. It should > > still be at least called out in the patch description if not actually > > split out into a separate patch (which would be ideal) - one of the > > things that really stands out in reviews is unrelated changes. > > I actually think there should have been two different patch sets. One > for the semi colon clean up, and the other to do the work for arrays. > The semi colon clean up is non-controversial as it is just a clean up > that does not affect the current code at all. > > But the added array preparation is not needed until we do the array > work, which deserves its own patch set.
OK, I'll split those patches.
Thanks,
Mathieu
> > -- Steve > >
-- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com
| |