Messages in this thread | | | Date | Tue, 3 May 2011 10:22:34 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/4] perf: Add persistent event facilities |
| |
* Borislav Petkov <bp@amd64.org> wrote:
> > we could move the other perf_events.c facilities there as well, and maybe > > split up the file a bit, it's 7.5 KLOC now which is a bit excessive. > > Right, so I left perf_event.c as a whole on purpose (only renamed) because it > makes more sense IMHO for someone who actually wrote it to split it in > logical parts (^hint hint^). I mean, I could do it too but it'll take me much > more time :).
Well you are now writing new events code as well so spending that time might be a good investment in terms of getting persistent.c right as well.
Could you send a Git pull request against perf/core that does the obvious file movement and renaming? We can do that first step straight away and get the ball rolling.
Thanks,
Ingo
| |