Messages in this thread | | | Date | Tue, 3 May 2011 18:47:11 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] regulator: Put mutex lock down to mc13783_powermisc_rmw function |
| |
On Wed, May 04, 2011 at 12:40:30AM +0800, Axel Lin wrote: > mc13783_powermisc_rmw function is doing read/modify/write bitmask operations, > thus add the lock to protect it. > Then we can remove the lock/unlock from the caller.
This should be squashed in with the MFD patch I think otherwise we'll get bisection points with either no lock or double locking (which upsets lockdep IIRC). The change itself looks good, though, and similarly for patch 2
| |