Messages in this thread | | | Date | Tue, 3 May 2011 16:21:40 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: Remove mc13xxx_unlock in regulator_register failure path |
| |
On Tue, May 03, 2011 at 11:15:04PM +0800, Axel Lin wrote: > We do not hold the mutex_lock of struct mc13xxx while calling regulator_register, > Thus remove mc13xxx_unlock in regulator_register failure path.
This feels painful, we shouldn't have to be faffing about with the lock like this for basic I/O operations. It feels like we should be pushing the lock down into the register access functions - looking at the driver I can't really see any reason why all this stuff is being done by hand, especially when we've got explicit read/modify/write bitmask operations.
| |